feat: C SSHNPD --monitor-read-timeout flag
#1458
Open
+19
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the default constant to |
XavierChanth
requested review from
gkc and
srieteja
and removed request for
XavierChanth
|
Most of the changes were in at_c where I was able to handle the socket code. It turns out mbedtls does have handlers for socket closed, but they shouldn't fully be relied on. We do check for them now, but there are also scenarios where the monitor connection is dead and the socket is still considered open, hence we have configured noop to 45 seconds in this PR. This noop is only called if the connection has silently failed since the frequency of stats notifications is more often. |
It is the correct place, but I renamed it to main.h to be more appropriate. |
XavierChanth
force-pushed
the
jt/update_noports
branch
from
c58a909 to
693870e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
--monitor-read-timeoutoption in C SSHNPDHow it works:
Let's say the monitor read timeout is 10 seconds.
Then the monitor connection will do a blocking read on the network buffer for 10 seconds before giving up. Once it gives up, it will send
noop:0\r\nto do a check if the monitor connection is alive.With this new implementation, the monitor connection will only send a
noop:0\r\neverymonitor-read-timeoutseconds, at most.- Description for the changelog
feat: C SSHNPD
--monitor-read-timeoutflag